Skip to content

🎨 [Frontend] Enh: users are identified by username #6934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Dec 11, 2024
Merged

🎨 [Frontend] Enh: users are identified by username #6934

merged 23 commits into from
Dec 11, 2024

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Dec 10, 2024 •
edited
Loading

What do these changes do?

  • userName is the new (visual) unique identifier for users
    • If you want to add a new user to an organization, this is now done by typing their userName instead of email
    • The email still can be used if the user to be added doesn't hide their email in the Privacy settings
  • first_name, last_name and email are optional for known-users.
  • Fix current master, by casting the group_ids and user_ids to integers.

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Dec 10, 2024
@odeimaiz odeimaiz added this to the Event Horizon milestone Dec 10, 2024
@odeimaiz odeimaiz self-assigned this Dec 10, 2024
@pcrespov pcrespov mentioned this pull request Dec 10, 2024
Merged
@odeimaiz odeimaiz marked this pull request as ready for review December 11, 2024 08:54
GitHK
GitHK reviewed Dec 11, 2024
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz odeimaiz enabled auto-merge (squash) December 11, 2024 10:11
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

pcrespov
pcrespov reviewed Dec 11, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for casting uid and gids from #6939. Not sure whether now the front-end will break if the value is already int

@odeimaiz
Copy link
Member Author

odeimaiz commented Dec 11, 2024

No need for casting uid and gids from #6939. Not sure whether now the front-end will break if the value is already int

Nope, it will just keep the int, np.

@odeimaiz odeimaiz merged commit 7f9f92f into ITISFoundation:master Dec 11, 2024
55 checks passed
@odeimaiz odeimaiz deleted the enh/username-instead-of-email branch December 11, 2024 11:59
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Dec 11, 2024
Closed
17 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 15, 2025
Closed
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GitHK GitHK GitHK left review comments

@pcrespov pcrespov pcrespov left review comments

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@ignapas ignapas Awaiting requested review from ignapas

@sanderegg sanderegg Awaiting requested review from sanderegg

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo

+1 more reviewer

@jsaq007 jsaq007 jsaq007 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@odeimaiz odeimaiz

Labels

a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature

Projects

None yet

Milestone

Event Horizon

Development

Successfully merging this pull request may close these issues.

5 participants

@odeimaiz @jsaq007 @GitHK @pcrespov @matusdrobuliak66